test(CI): Have GitHub use npm ci instead of npm install#8245
Merged
cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom Jul 9, 2024
Merged
test(CI): Have GitHub use npm ci instead of npm install#8245cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom
npm ci instead of npm install#8245cpcallen merged 1 commit intoRaspberryPiFoundation:developfrom
Conversation
Collaborator
Author
|
OK the |
Collaborator
Author
|
OK, rebasing this onto a known-good commit did not cause tests to start passing, because it turns out that the checkout workflow checks out a commit that's a merge commit merging the PR into Not sure when that changed but obviously it's a lot better because it tells you if your PR will break |
cpcallen
added
component: tests
PR: chore
gonfunko
approved these changes
Jul 8, 2024
This should help ensure that CI catches PRs that update package.json without updating package-lock.json to match. Proposed in response to breakage caused by PR RaspberryPiFoundation#8209.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Have the GitHub
buildworkflow, which runs our tests, usenpm ciinstead ofnpm installwhen installing dependencies.Reason for Changes
This should help ensure that CI catches PRs that update
package.jsonwithout updatingpackage-lock.jsonto match.Additional Information
Proposed in response to breakage caused by PR #8209.